Capture & emission fidelity wave: dotLottie support, scroll-state isolation, authored-geometry trust, honest quality scoring

Capture: - Preserve real asset extensions (.lottie no longer truncated); extract the default animation JSON from dotLottie ZIP containers at materialization (minimal built-in ZIP reader, no new deps) - Reset scroll + settle before every viewport snapshot so scroll-linked styles can't bake into captured computed values - Marquee detection now requires content overflow (>1.35x), sustained velocity across separated windows, scroll independence (jiggle test), and genuine content repetition — kills scroll-settle-lerp false positives - Sizing probe trusts authored explicit heights (px/vh/calc) over circular parent/child reflow verdicts, fixing dropped 100vh heroes Normalize/generate: - Canonicalize identity transforms to "none" per viewport; emit explicit transform resets across bands when any band has a real transform - DittoLottie keeps the captured placeholder until DOMLoaded; failed loads no longer blank the container - mx-auto only for true auto-margin centering; literal per-band margins are preserved (fixes full-bleed regressions) - Spacing-scale snap tightened to 0.25px (3.5px stays p-[3.5px]); emit whitespace-nowrap for wrap-vulnerable single-line text leaves - Grid recipes no longer override captured track counts or column spans; responsive re-flow plans apply only when geometry agrees Quality scoring: - Rewritten 6-dimension rubric (payload, decomposition, duplication, semantics, hygiene, runtime) with catastrophe caps and per-dimension reporting; thresholds are documented calibration guides 218 tests pass (74 new), typecheck clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-03 23:09:16 -07:00
parent 77be868ee3
commit d3ec154bae
19 changed files with 2345 additions and 386 deletions
@@ -0,0 +1,146 @@
+import { describe, it } from "node:test";
+import assert from "node:assert/strict";
+import { deflateRawSync } from "node:zlib";
+import { isZipArchive, extractDotLottieJson, readZipEntry } from "../src/capture/dotlottie.js";
+import { extFromUrl } from "../src/capture/capture.js";
+
+/**
+ * Build a minimal, spec-correct ZIP archive in-memory from named entries. Supports both
+ * stored (method 0) and deflated (method 8) compression so the extractor is exercised on both.
+ * No CRC validation is needed for our reader, so CRC fields are left 0.
+ */
+function buildZip(entries: Array<{ name: string; data: Buffer; deflate?: boolean }>): Buffer {
+  const locals: Buffer[] = [];
+  const centrals: Buffer[] = [];
+  let offset = 0;
+
+  for (const e of entries) {
+    const nameBuf = Buffer.from(e.name, "utf8");
+    const stored = e.deflate ? deflateRawSync(e.data) : e.data;
+    const method = e.deflate ? 8 : 0;
+
+    const local = Buffer.alloc(30 + nameBuf.length);
+    local.writeUInt32LE(0x04034b50, 0); // local file header sig
+    local.writeUInt16LE(20, 4); // version needed
+    local.writeUInt16LE(0, 6); // flags
+    local.writeUInt16LE(method, 8);
+    local.writeUInt16LE(0, 10); // time
+    local.writeUInt16LE(0, 12); // date
+    local.writeUInt32LE(0, 14); // crc
+    local.writeUInt32LE(stored.length, 18); // comp size
+    local.writeUInt32LE(e.data.length, 22); // uncomp size
+    local.writeUInt16LE(nameBuf.length, 26);
+    local.writeUInt16LE(0, 28); // extra len
+    nameBuf.copy(local, 30);
+    const localFull = Buffer.concat([local, stored]);
+    locals.push(localFull);
+
+    const central = Buffer.alloc(46 + nameBuf.length);
+    central.writeUInt32LE(0x02014b50, 0); // central dir sig
+    central.writeUInt16LE(20, 4); // version made by
+    central.writeUInt16LE(20, 6); // version needed
+    central.writeUInt16LE(0, 8); // flags
+    central.writeUInt16LE(method, 10);
+    central.writeUInt16LE(0, 12); // time
+    central.writeUInt16LE(0, 14); // date
+    central.writeUInt32LE(0, 16); // crc
+    central.writeUInt32LE(stored.length, 20); // comp size
+    central.writeUInt32LE(e.data.length, 24); // uncomp size
+    central.writeUInt16LE(nameBuf.length, 28);
+    central.writeUInt16LE(0, 30); // extra
+    central.writeUInt16LE(0, 32); // comment
+    central.writeUInt16LE(0, 34); // disk
+    central.writeUInt16LE(0, 36); // internal attrs
+    central.writeUInt32LE(0, 38); // external attrs
+    central.writeUInt32LE(offset, 42); // local header offset
+    nameBuf.copy(central, 46);
+    centrals.push(central);
+
+    offset += localFull.length;
+  }
+
+  const centralStart = offset;
+  const centralDir = Buffer.concat(centrals);
+  const eocd = Buffer.alloc(22);
+  eocd.writeUInt32LE(0x06054b50, 0);
+  eocd.writeUInt16LE(0, 4); // disk
+  eocd.writeUInt16LE(0, 6); // cd start disk
+  eocd.writeUInt16LE(entries.length, 8);
+  eocd.writeUInt16LE(entries.length, 10);
+  eocd.writeUInt32LE(centralDir.length, 12);
+  eocd.writeUInt32LE(centralStart, 16);
+  eocd.writeUInt16LE(0, 20); // comment len
+
+  return Buffer.concat([...locals, centralDir, eocd]);
+}
+
+const ANIM_1 = { v: "5.7.4", nm: "one", layers: [{ ind: 1 }] };
+const ANIM_2 = { v: "5.7.4", nm: "two", layers: [{ ind: 2 }] };
+const MANIFEST = { version: "1.0", animations: [{ id: "animation_default" }, { id: "animation_2" }] };
+
+describe("dotLottie ZIP extraction", () => {
+  it("detects ZIP archives by the PK local-header magic", () => {
+    assert.equal(isZipArchive(Buffer.from([0x50, 0x4b, 0x03, 0x04, 0, 0])), true);
+    assert.equal(isZipArchive(Buffer.from('{"v":"5.7"}', "utf8")), false);
+    assert.equal(isZipArchive(Buffer.alloc(2)), false);
+  });
+
+  it("extracts the manifest's default animation JSON from a stored dotLottie ZIP", () => {
+    const zip = buildZip([
+      { name: "manifest.json", data: Buffer.from(JSON.stringify(MANIFEST), "utf8") },
+      { name: "animations/animation_default.json", data: Buffer.from(JSON.stringify(ANIM_1), "utf8") },
+      { name: "animations/animation_2.json", data: Buffer.from(JSON.stringify(ANIM_2), "utf8") },
+    ]);
+    const out = extractDotLottieJson(zip);
+    assert.ok(out, "expected an extracted animation buffer");
+    assert.deepEqual(JSON.parse(out!.toString("utf8")), ANIM_1);
+  });
+
+  it("extracts a DEFLATE-compressed animation entry (the common real-world case)", () => {
+    const zip = buildZip([
+      { name: "manifest.json", data: Buffer.from(JSON.stringify(MANIFEST), "utf8"), deflate: true },
+      { name: "animations/animation_default.json", data: Buffer.from(JSON.stringify(ANIM_1), "utf8"), deflate: true },
+    ]);
+    const out = extractDotLottieJson(zip);
+    assert.ok(out);
+    assert.deepEqual(JSON.parse(out!.toString("utf8")), ANIM_1);
+  });
+
+  it("falls back to the name-sorted first animation when the manifest is absent", () => {
+    const zip = buildZip([
+      { name: "animations/b.json", data: Buffer.from(JSON.stringify(ANIM_2), "utf8") },
+      { name: "animations/a.json", data: Buffer.from(JSON.stringify(ANIM_1), "utf8") },
+    ]);
+    const out = extractDotLottieJson(zip);
+    assert.ok(out);
+    assert.deepEqual(JSON.parse(out!.toString("utf8")), ANIM_1); // "a.json" sorts first
+  });
+
+  it("returns null for non-ZIP bytes and for a ZIP with no animations", () => {
+    assert.equal(extractDotLottieJson(Buffer.from('{"v":"5.7"}', "utf8")), null);
+    const noAnims = buildZip([{ name: "manifest.json", data: Buffer.from("{}", "utf8") }]);
+    assert.equal(extractDotLottieJson(noAnims), null);
+  });
+
+  it("reads a named entry directly", () => {
+    const zip = buildZip([{ name: "manifest.json", data: Buffer.from(JSON.stringify(MANIFEST), "utf8"), deflate: true }]);
+    const m = readZipEntry(zip, "manifest.json");
+    assert.ok(m);
+    assert.deepEqual(JSON.parse(m!.toString("utf8")), MANIFEST);
+    assert.equal(readZipEntry(zip, "missing.json"), null);
+  });
+});
+
+describe("asset extension preservation (extFromUrl)", () => {
+  it("preserves real long extensions instead of truncating to 5 chars", () => {
+    assert.equal(extFromUrl("https://x/anim.lottie"), "lottie");
+    assert.equal(extFromUrl("https://x/site.webmanifest"), "webmanifest");
+    assert.equal(extFromUrl("https://x/pic.png?v=2"), "png");
+    assert.equal(extFromUrl("https://x/font.woff2"), "woff2");
+  });
+
+  it("rejects absurdly long or non-alphanumeric trailing segments", () => {
+    assert.equal(extFromUrl("https://x/name.thisisnotanextension"), "");
+    assert.equal(extFromUrl("https://x/dir.with.dots/file"), ""); // dot is in a path segment, not the file
+  });
+});